Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Render emojis at GitHub Repo Page #8444

Closed
schmelto opened this issue Aug 1, 2023 · 24 comments
Closed

[BUG] Render emojis at GitHub Repo Page #8444

schmelto opened this issue Aug 1, 2023 · 24 comments
Assignees
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@schmelto
Copy link
Contributor

schmelto commented Aug 1, 2023

Description

Emojis of Github Repository descriptions are not rendered.

Screenshots

image

Additional information

No response

@schmelto schmelto added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Aug 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

To reduce notifications, issues are locked until they are https://github.com/EddieHubCommunity/LinkFree/labels/%F0%9F%8F%81%20status%3A%20ready%20for%20dev and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
@SaraJaoude
Copy link
Member

Thanks for raising!

@SaraJaoude SaraJaoude added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) 🔢 points: 3 undefined and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Aug 3, 2023
@github-actions github-actions bot unlocked this conversation Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/LinkFree/blob/main/CONTRIBUTING.md

@rajpatelbot
Copy link
Contributor

Can I work on this issue?

@SaraJaoude
Copy link
Member

Can I work on this issue?

@rajpatelbot I have assigned this to you.

@mkubdev
Copy link
Contributor

mkubdev commented Aug 4, 2023

Hi, a precision to add:

  • Currently, the format of emoji print as colon-sequences like :man_technologist: (👨‍💻). => The fix would be to converts colon-sequences emoji to display them on the browser.

@rajpatelbot
Copy link
Contributor

Hey thanks for this great explaination

@eddiejaoude
Copy link
Member

Also it would be worth checking what library GitHub uses for this and other alternative libraries

@rajpatelbot rajpatelbot removed their assignment Aug 20, 2023
@rajpatelbot
Copy link
Contributor

Hey sorry for this. But i am unassigned it because i am busy with some other stuff.

Thank you for understanding

@Dobariya-Nishant
Copy link
Contributor

i want to help in this issue.

@SaraJaoude
Copy link
Member

i want to help in this issue.

@Dobariya-Nishant I have assigned this to you

@Dobariya-Nishant
Copy link
Contributor

after some research i found this twemoji (https://github.com/twitter/twemoji) library which is used by GitHub, Discord, Twitter and WordPress.
also found alternative library's like Js-emogi (https://github.com/iamcal/js-emoji) and node-emoji (https://www.npmjs.com/package/node-emoji).

i think twemoji is good option because its can be easy to sync emojis between github repo and BioDrop.

@eddiejaoude
Copy link
Member

Sounds good, let's go for twemoji but don't use the CDN, we need to have it as part of our npm dependencies

@SaraJaoude SaraJaoude added the Hacktoberfest Good issues for Hacktoberfest participants label Oct 1, 2023
@SaraJaoude
Copy link
Member

@Dobariya-Nishant due to lack of activity I will unassign this from you.

@nitheesh-daram
Copy link
Member

Hey, can I be assigned to this?

@harshbsharma
Copy link

I would like to solve this. Please assign

@mkubdev
Copy link
Contributor

mkubdev commented Oct 17, 2023

Hi, can you assign me this issue?

@SaraJaoude
Copy link
Member

Hey, can I be assigned to this?

@nitheesh-daram I will assign this to you - please make sure that you read through the history of the comments before raising the PR so that you can see what has been discussed.

@SaraJaoude
Copy link
Member

Hey, can I be assigned to this?

nitheesh-daram I will assign this to you - please make sure that you read through the history of the comments before raising the PR so that you can see what has been discussed.

@nitheesh-daram how are you getting on?

@acharyamanish006
Copy link

since there has been no activity for 2 weeks I would like to work on this issue.

@SaraJaoude
Copy link
Member

Hey, can I be assigned to this?

nitheesh-daram I will assign this to you - please make sure that you read through the history of the comments before raising the PR so that you can see what has been discussed.

nitheesh-daram how are you getting on?

@nitheesh-daram as we did not hear from you and it has been two weeks I am unassigning this from you.

@SaraJaoude
Copy link
Member

since there has been no activity for 2 weeks I would like to work on this issue.

@acharyamanish006 I have assigned this to you. Please take into consideration what has been mentioned here: #9500 (comment)

@acharyamanish006
Copy link

Issues with emojis in repository descriptions not rendering consistently on GitHub.

I tried replicating it locally, but it seems to be working fine on my end. someone might have resolved the problem.

If you could confirm this, it would be greatly appreciated.

Please investigate this matter.

Screenshot from 2023-10-31 18-11-51

@SaraJaoude
Copy link
Member

Thank you for testing @acharyamanish006 - as this appears to be fixed, I will close.

@SaraJaoude SaraJaoude closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined Hacktoberfest Good issues for Hacktoberfest participants 🔢 points: 3 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

9 participants