Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reflect network requests on button #287

Open
kailash360 opened this issue Oct 27, 2022 · 8 comments
Open

[Feature] Reflect network requests on button #287

kailash360 opened this issue Oct 27, 2022 · 8 comments
Assignees

Comments

@kailash360
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, whenever any request is made on clicking a button, the state of the button does not change.This creates a dilemma if the request has been made or not,until a proper response is received.

Describe the solution you'd like

The requests should be reflected on the button. It should be done by disabling the button whenever the button is clicked till the request is under process. Preferably it should also show a loader for better UX.

Additional context

Story - https://userstory.site/story/60e59aa42d674800150f759e

@kunal00000
Copy link
Contributor

Can I take up this issue?
I have set up the project locally.

@codetheorem
Copy link
Member

codetheorem commented Dec 11, 2022

Can I take up this issue?
I have set up the project locally.

Sure go ahead @kunal00000

@kunal00000
Copy link
Contributor

Hi @codetheorem , can I get slack invite.
link in the readme file is broken and previous year gsoc page Invite link was broken therefore could not join slack.

@codetheorem
Copy link
Member

Hi @codetheorem , can I get slack invite.
link in the readme file is broken and previous year gsoc page Invite link was broken therefore could not join slack.

https://eos-community.slack.com/

@kunal00000
Copy link
Contributor

through this person cannot be joined without being part of organisation on slack invite link needed for new participant to join.
also please tell me which button is referred in the issue?

@codetheorem
Copy link
Member

through this person cannot be joined without being part of organisation on slack invite link needed for new participant to join. also please tell me which button is referred in the issue?

Buttons which are connected with an async callback.

@kunal00000
Copy link
Contributor

Review if button should work like this as shown

Screen.Recording.2022-12-27.at.8.44.38.PM.mov

@kunal00000
Copy link
Contributor

Please review the pr linked to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants