Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypress of "ESC" key on double-tapped OSL layer does not work after OSL escape timeout. #16

Open
rainyrainyday opened this issue May 3, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@rainyrainyday
Copy link

rainyrainyday commented May 3, 2022

Describe the bug
Pressing the Esc key on a layer that was moved to using OSL double-tap causes a return to last moved layer if its within 2-3 seconds. After that timeout period, ESC key does not work normally.

To Reproduce
Steps to reproduce the behavior:

  1. Set up 2-dot left thumb key to OSL 8
  2. Set up same key on Layer 8 to transparent
  3. Set up top left most key as Trans (from Layer 1) or ESC
  4. Double tap 2-dot left thumb key to trigger OSL Move to Layer 8
  5. Press any key in Layer 8 (optional)
  6. Wait 3-5 seconds, press the key bound to ESC.
  7. Normal ESC behavior does not occur.

Expected behavior
Pressing Esc key after double tapping an OSL key should not cancel OSL and return to previous layer after timeout. Normal ESC behavior should happen.

Desktop (please complete the following information):

  • OS: Windows 10
  • Bazecor Version: 1.0.0 Beta 14
  • Firmware: 1.0.8beta
@rainyrainyday rainyrainyday added the bug Something isn't working label May 3, 2022
@rainyrainyday
Copy link
Author

rainyrainyday commented May 5, 2022

Behavior from a Kaleidoscope plugin: https://kaleidoscope.readthedocs.io/en/latest/plugins/Kaleidoscope-Escape-OneShot.html. This behavior should be configurable: to continue treating ESC as an OSL cancel key or to return ESC to normal behavior (i.e. to exit OSL, one has to tap the original OSL key instead of ESC).

@rainyrainyday rainyrainyday reopened this May 7, 2022
@rainyrainyday rainyrainyday changed the title Keypress of "ESC" key on double-tapped OSL layer navigates to previous layer Keypress of "ESC" key on double-tapped OSL layer does not work after OSL escape timeout. May 7, 2022
@alexpargon alexpargon transferred this issue from Dygmalab/Bazecor Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant