Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort order of Group By Class in review mode #148

Open
manthey opened this issue Sep 26, 2024 · 1 comment
Open

Sort order of Group By Class in review mode #148

manthey opened this issue Sep 26, 2024 · 1 comment

Comments

@manthey
Copy link
Contributor

manthey commented Sep 26, 2024

I would expect grouping by class (label) to be in the same order that our labels are listed in the categories palette, but this isn't the case in my sample (on the refactor-filtering-ui branch).

Also, we call these alternately Label, Category, and Class. Should we harmonize this?

@bnmajor
Copy link
Collaborator

bnmajor commented Sep 26, 2024

I would expect grouping by class (label) to be in the same order that our labels are listed in the categories palette, but this isn't the case in my sample (on the refactor-filtering-ui branch).

I personally think that keeping it in alphabetical order (as it is currently) feels the most natural, although I'm not opposed to matching the palette ordering if that is the overall desire. If we keep alphabetical we could also add the ascending/descending toggle button that we have for the sort menu.

Also, we call these alternately Label, Category, and Class. Should we harmonize this?

Absolutely. After our most recent meeting it seems the consensus is to at least remove all instances of category. I will make these changes in their own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants