Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pixiv] Key constraint for metadata plugin on "date_uploaded" and "artist" #1140

Open
psilabs-dev opened this issue Dec 29, 2024 · 0 comments

Comments

@psilabs-dev
Copy link
Contributor

It came to mind that the metadata plugin for pixiv doesn't enforce uniqueness on certain tags, which can result in data integrity issues. In particular, the values for "date_uploaded" and "artist" should be unique when called by the pixiv metadata plugin on an artwork ID.

Case for "date_uploaded": If an artist privates their artwork and unprivates it, the date of upload will change to the more recent unprivated date. The metadata plugin should overwrite the date_uploaded field so that any archive should only reflect the most recent uploaded date.

Case for "artist": Pixiv archives always have exactly one artist. If the Pixiv artist changes their name, the name of the artist corresponding to the artwork should be changed to the new name, rather than having both new and old names.

Other tags like "pixiv_user_id" or "source" or "date_created" are assumed to never change, so they're OK.

This is probably a theoretical bug I don't think many people have run into; it requires you to call the plugin on an already-tagged archive in which the source upload date or artist name have changed, but I should fix this sometime in the future.

@psilabs-dev psilabs-dev changed the title [Pixiv] Uniqueness for metadata plugin on "date_uploaded" and "artist" [Pixiv] Key constraint for metadata plugin on "date_uploaded" and "artist" Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant