Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/styling fixes #51

Merged
merged 8 commits into from
Jan 9, 2024
Merged

Feat/styling fixes #51

merged 8 commits into from
Jan 9, 2024

Conversation

Markkos89
Copy link
Collaborator

@Markkos89 Markkos89 commented Jan 9, 2024 •
edited
Loading

Changes

  • tracklayout enhancements
  • trackspage divided at half and with correct image now (overflow is not hidden yet)
  • tags enhanced among pages
  • some little css enhancements around
  • created a TODO list

@Markkos89 Markkos89 added the enhancement New feature or request label Jan 9, 2024
@Markkos89 Markkos89 self-assigned this Jan 9, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 10:27pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 10:27pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 96
🟠 Best practices 75
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-feat-styling-fixes-developdao.vercel.app/

elPiablo
elPiablo approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@elPiablo elPiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, Marcos!!

@Markkos89 Markkos89 merged commit 087feb3 into main Jan 9, 2024
3 checks passed
@Markkos89 Markkos89 deleted the feat/styling-fixes branch January 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elPiablo elPiablo elPiablo approved these changes

@wolovim wolovim Awaiting requested review from wolovim

@recepcankaya recepcankaya Awaiting requested review from recepcankaya

@code-z2 code-z2 Awaiting requested review from code-z2

@okhaimie-dev okhaimie-dev Awaiting requested review from okhaimie-dev

Assignees

@Markkos89 Markkos89

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Markkos89 @elPiablo