Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users about secret config values #938

Open
2 tasks
jordanstephens opened this issue Jan 6, 2025 · 2 comments
Open
2 tasks

Warn users about secret config values #938

jordanstephens opened this issue Jan 6, 2025 · 2 comments
Assignees
Milestone

Comments

@jordanstephens
Copy link
Member

jordanstephens commented Jan 6, 2025

Customers are storing secrets as plain text environment variables, this is a security risk for the customers, the plain text secrets should not leave the user's computer.

@lionello
Copy link
Member

lionello commented Jan 8, 2025

Can't find what GitHub uses but their docs are here: https://docs.github.com/en/enterprise-cloud@latest/code-security/secret-scanning/secret-scanning-patterns#supported-secrets

Yelp has https://github.com/Yelp/detect-secrets which works well for our cause, it found all secrets in one of our tenants:

[
      {
        "type": "Base64 High Entropy String",
        "filename": "ii",
        "hashed_secret": "5441477719707ecbf36feed87dd3e2916004887b",
        "is_verified": false,
        "line_number": 15
      },
      {
        "type": "Secret Keyword",
        "filename": "ii",
        "hashed_secret": "5441477719707ecbf36feed87dd3e2916004887b",
        "is_verified": false,
        "line_number": 15
      },
      {
        "type": "Base64 High Entropy String",
        "filename": "ii",
        "hashed_secret": "87f33ee635332cf5987b3a84b07271ccaca01b75",
        "is_verified": false,
        "line_number": 16
      },
      {
        "type": "Secret Keyword",
        "filename": "ii",
        "hashed_secret": "87f33ee635332cf5987b3a84b07271ccaca01b75",
        "is_verified": false,
        "line_number": 16
      },
      {
        "type": "Basic Auth Credentials",
        "filename": "ii",
        "hashed_secret": "7f5339e9175001ce2287e521265100274df0b761",
        "is_verified": false,
        "line_number": 18
      },
      {
        "type": "Basic Auth Credentials",
        "filename": "ii",
        "hashed_secret": "1ee439b2de2e90309ce03e8c14c0f84b06b43d76",
        "is_verified": false,
        "line_number": 19
      }
   ]

@lionello
Copy link
Member

lionello commented Jan 8, 2025

Golang "fork" https://github.com/DefangLabs/secret-detector

@commit111 commit111 added this to the Jan2025 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants