Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Lore text on enchantable items visually not mixing well #251

Open
Shibva opened this issue Aug 29, 2023 · 1 comment
Open

[Feature] Lore text on enchantable items visually not mixing well #251

Shibva opened this issue Aug 29, 2023 · 1 comment
Labels
enhancement New feature or request low_priority Nice to have, additional features

Comments

@Shibva
Copy link
Contributor

Shibva commented Aug 29, 2023

Describe the bug
On some of the item lore for items that can be enchanted, there's is a lack of indication of lore separating from Enchantments that make it seem like it's one blob of lore. This is not visually appealing.

To Reproduce
Should be self-explanatoy; for best results, enchant a Molten rod and you will see what I mean

Expected behavior
I'm thinking something could be done to fix this issue, whether it be via changing the text color or applying a new line to it.

This is in my scope of being able to contribute so I could make a pull request to propose changes to the log file; thought I would like to clarify what you would prefer out of these options:

  • Change the color of the lore text
    Or
  • Introduce a \n where needed to create a distinct space between lore and enchantments

Let me know what you prefer and I'll work on it :D

@DaFuqs
Copy link
Owner

DaFuqs commented Oct 12, 2023

I'll have to think about this some more. Definitely a valid concern.

@DaFuqs DaFuqs added the low_priority Nice to have, additional features label Oct 12, 2023
@DaFuqs DaFuqs added the enhancement New feature or request label Aug 14, 2024
@DaFuqs DaFuqs changed the title [QoL potential bug] Lore text on enchantable items visually not mixing well [Feature] Lore text on enchantable items visually not mixing well Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low_priority Nice to have, additional features
Projects
None yet
Development

No branches or pull requests

2 participants