-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run_external_job
to work with updated interface implementation
#179
Comments
The models are auto extracted. So the I do think it wise do some pre-flight checking on the client side. As such, updating those pre-flight checks make sense and should be pretty straight forward. |
Ah nice! I didn't know that. So adding a serializer in GC for the new model is enough for gcapi to pick it up? |
The picking up is still a script that needs to be ran by a developer. But yes =) |
Check! I almost thought magic was involved ;-) But what I meant to clarify is that having a serializer is enough, no need for an API view, right? |
As long as it shows up via the schema it should suffice: Line 16 in a802507
I think that if you make the serializer referenced via a field in |
With the introduction of optional inputs (https://github.com/DIAGNijmegen/rse-roadmap/issues/153), scheduling jobs through the API via the
run_external_job
helper function will break as soon as people update or add new interfaces to their algorithms.The
run_external_job
function currently checks if the provided inputs match those defined on the algorithm.We need to decide if we want to keep those checks here. The checks already happen on GC, so we could also remove them here, but then again it's good to do some quality checking...
If we want to keep the checks, they will need to be updated to check whether the inputs match any of the possible input sets of the algorithm.
To be able to do that:
Algorithm
model in gcapi will need to be updated to reflect the move frominputs
andoutputs
tointerfaces
.AlgorithmInterface
model and aAlgorithmInterfaceAPI
that map to the new endpoint.The text was updated successfully, but these errors were encountered: