Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added alerts on UI when user log-in/log-out, enters wrong password/captcha or unregistered email. #649

Merged
merged 3 commits into from
May 30, 2024

Conversation

yashi-15
Copy link
Contributor

Description

I have added ALERTS/ TOAST NOTIFICATION on UI for,

  1. User successfully loged-in or logged-out
  2. Enters unregistered email while login.
  3. Enters wrong password or captcha

Fixes #636

Screenshots

Screenshot (517)
Screenshot (518)
Screenshot (514)
Screenshot (515)
Screenshot (519)

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

Copy link

netlify bot commented May 30, 2024

👷 Deploy request for counsellor-startup pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 57649c1

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Contributor

deepsource-io bot commented May 30, 2024

Here's the code health analysis summary for commits be9db53..57649c1. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
🎯 7 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@thestarsahil
Copy link
Collaborator

Screenshot from 2024-05-30 20-17-12

As you can see logged in pop message hiding under navbar , Shift down downwards navbar so , we can see two pop message clearly !
Thanks

@Soumya-RanjanSwain
Copy link

Yes he have done the toasters, I will be implementing the autocomplete and other stuffs to get rid of the warnings and errors from the console

@yashi-15
Copy link
Contributor Author

yashi-15 commented May 30, 2024

Screenshot from 2024-05-30 20-17-12

As you can see logged in pop message hiding under navbar , Shift down downwards navbar so , we can see two pop message clearly ! Thanks

I have made the changes. Please review them ... @thestarsahil. Let me know if any other changes are required.

Screenshot (520)

@thestarsahil
Copy link
Collaborator

Screenshot from 2024-05-30 22-26-16

It should be same as Logout pattern !

@yashi-15
Copy link
Contributor Author

Done! @thestarsahil
Screenshot (522)
Screenshot (524)

Copy link
Collaborator

@thestarsahil thestarsahil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working Perfect ! Well Done

@thestarsahil thestarsahil merged commit 72d746f into Counselllor:master May 30, 2024
2 checks passed
@thestarsahil thestarsahil added gssoc for GSSOC'24 contributors level3 labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc for GSSOC'24 contributors level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving some bugs when user tries to signup/login.
3 participants