Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing the Search Bar #570

Closed
ayush-848 opened this issue May 23, 2024 · 19 comments · Fixed by #588
Closed

Enhancing the Search Bar #570

ayush-848 opened this issue May 23, 2024 · 19 comments · Fixed by #588
Assignees
Labels
assigned gssoc for GSSOC'24 contributors level2

Comments

@ayush-848
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The search bar does not look good. The placeholder text needs to be more lighter. The background should have been much more lighter or as the same as that of the website

Describe the solution you'd like
I would like to manage the background of the navbar and if permitted I would like to add hover effect on the search button

Copy link

Hello ayush-848, Thanks for opening an issue, your contribution is valuable to us. The maintainers will review this issue and provide feedback as soon as possible.

@ayush-848
Copy link
Contributor Author

@thestarsahil If you think that the navbar does have its issue, please assign this to me. I would also like to have your inputs here.

@thestarsahil
Copy link
Collaborator

Shortlist major problem in one go , I am accepting those issue who are working in 5 different area !
Not accepting those who gonna work on single issue !

Your 2 problem shortlisted ! I am assigning for this now

@thestarsahil
Copy link
Collaborator

Welcome @ayush-848

@ayush-848
Copy link
Contributor Author

Shortlist major problem in one go , I am accepting those issue who are working in 5 different area ! Not accepting those who gonna work on single issue !

Your 2 problem shortlisted ! I am assigning for this now

Hey @thestarsahil didn't quite understood what you were trying to convey.

@ayush-848
Copy link
Contributor Author

Do you mean to say that there are multiple people working on this section (i.e navbar)

@thestarsahil
Copy link
Collaborator

We are accepting majorly those PR , those contributor repeatedly contribute !
I mean not like only single contribution towards the project !

@ayush-848
Copy link
Contributor Author

Oh ok

@ayush-848
Copy link
Contributor Author

ayush-848 commented May 24, 2024

@thestarsahil
image
how does it look?? please check PR #588

@thestarsahil
Copy link
Collaborator

There is not much gap between the img and the border in the searchbar

@ayush-848
Copy link
Contributor Author

There is not much gap between the img and the border in the searchbar

image

are you talking about this part??

@thestarsahil
Copy link
Collaborator

@ayush-848 Yes

@ayush-848
Copy link
Contributor Author

@thestarsahil now see
image

@thestarsahil
Copy link
Collaborator

Inside the Search bar div element , that should be round from the corner as you can see the outer round its mild curve !

@ayush-848
Copy link
Contributor Author

Inside the Search bar div element , that should be round from the corner as you can see the outer round its mild curve !

The search image???

@thestarsahil
Copy link
Collaborator

Inside the Search bar div element , that should be round from the corner as you can see the outer round its mild curve !

The search image???

No , as you can see the element written => Type college name or university name
from the side corner it should be little curve not rectangle corner

@ayush-848
Copy link
Contributor Author

oh understood

@ayush-848
Copy link
Contributor Author

@thestarsahil
image
please check

@thestarsahil
Copy link
Collaborator

thestarsahil commented May 25, 2024

Update the PR from your side !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned gssoc for GSSOC'24 contributors level2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants