Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results would be different if the outputs generated by the previous analysis were not removed #2

Closed
Clifford-Yen opened this issue May 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Clifford-Yen
Copy link
Owner

Clifford-Yen commented May 21, 2024

If the outputs generated by the previous analysis exist in the paths defined in the parameters.in (or not defined so that the default paths are used), the following analysis would generate unexpected results.

@Clifford-Yen Clifford-Yen added the bug Something isn't working label May 21, 2024
@Clifford-Yen
Copy link
Owner Author

Although the root cause of this issue is still being investigated, Hercules now removes all files in the source output folder that were created by Hercules (force_process.* and sourcedescription.out) before creating any source-related files, which should be enough to solve this problem entirely.

All versions starting from ab6d296 should be free from this issue.

@Clifford-Yen Clifford-Yen self-assigned this May 21, 2024
@Clifford-Yen
Copy link
Owner Author

The files in the source output folder (force_process.* and sourcedescription.out) might no be the problem that makes the result different. It's still more likely a topography or damping issue. Check #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant