-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDDM theme with Autologin #381
Conversation
And please don't open any more PRs for the same thing |
@mashrukk Don't make any more changes to this. It's perfect how it is now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the time of reviewing; might be different if anything changes. (needs testing aswell)
@mashrukk These are the last 2 changes we request of you, thank you for your contribution otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @nnyyxxxx said: this needs testing, the commits need squashing. (not quoting)
Code looks good for now, although this might change after the tests. I could test this out later when I'm able to, then I'll approve the changes.
@adamperkowski check invite |
@mashrukk got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamperkowski To check dependencies required visit sddm-astronaut-theme |
Duplicate of #228 partially |
@guruswarupa I appreciate your work. Instead of making a separate autologin script. It's better to have SDDM with auto login functionality. |
my script auto-login is for multiple display managers. this pr should just work on setting up the theme and not adding features such as autologin which is part of util features, wherein user can choose to keep autologin on or not. what if he doesn't need autologin but wants to have the theme setup? hope you get my point. |
whats your take on it? @adamperkowski @nnyyxxxx |
@guruswarupa Check the script. It doesn't just set up a theme. It installs SDDM with the theme and asks the user if they want to auto-login, which is optional. |
@mashrukk yeah fine, also restarting sddm without asking user is unexpected behavior for script to do. |
if its added to the sddm.conf, automatically when user restarts the theme should be loaded. in the sddm install add sudo systemctl enable sddm.service |
Pull Request
SDDM Astronaut theme with Autologin
This script installs sddm-astronaut-theme from last stream and provides an option to enable autologin with sddm. Users can choose which desktop session they want to autologin on startup. After selecting desktop session, it will do a sddm restart and autologin to that desktop.
Testing
If you want to test it first, do the following.
Type of Change
Checklist