Remove nullable, nonnull, const from initWithAddress

[ma11hew28]

Why are those keywords included here:

https://github.com/ChatSecure/SignalProtocol-ObjC/blob/master/Classes/Models/SignalAddress_Internal.h#L17

They are not included for SignalPreKey or SignalSignedPreKey.

[ma11hew28]

Also, it might be nice to add newlines to SignalPreKey_Internal.h & SignalSignedPreKey_Internal.h to keep the line-spacing consistent with the other internal header files.

[chrisballinger]

What keywords? signal_protocol_address is internal to the C implementation and shouldn't be exposed to the public Obj-C headers.

Btw I'm curious, are you planning on using this library in a shipping product, or just poking around? Make sure to be mindful of the GPL/App Store license, as there's still no straightforward way to get a closed source exception from Moxie, to my knowledge.

[ma11hew28]

I was referring to the keywords nullable, nonnull, and const. I don't understand why -[SignalAddress initWithAddress:] and -[SignalSignedPreKey initWithSignedPreKey] are different. I also didn't know what nullable and nonnull meant, but now that I do, it seems like at least nonnull can be removed.

OK. Thank you for that information. We're planning on using this library in a shipping iPhone app. Do we have to open source our server code too if it doesn't use any Signal libraries?

[chrisballinger]

What's the app? You'll need to release all of the source code, including all linked 3rd party dependencies, and make sure that your app's license is compatible with the GPL: https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses

You don't need to open source your server, but you should consider it if you're offering people a "secure" messenger.