Small picture (logo) per card #8
Comments
TheLastProject
added
the
state: help wanted
|
Before creating this application I took a look at Stocard and a few others and how they worked. My concern with packaging the logos in the app is a legal one (discussion here). It is not clear to me if I would need to get permission from each company in writing prior to packaging their logo into the application and using it. Stocard's model appears to be based on partnerships with retailers. Although I do not know for sure, I suspect Stocard has the permission of the 1800 companies (as reported on Google Play) whose logo it uses. It is unfortunately more complicated than all of that, however. This application is free (as in speech and beer) because of the license I have selected (GPLv3). To provide the assets with the same freedom if a logo from another company were to be included the company would need to give permission not only to me but to anyone who would fork this project, not knowing what they may do with it. In the end, I am glad to provide an application that I (and hopefully others) find useful. I do not want to expose myself to legal trouble, nor be able to provide the application with the level of freedom and flexibility I expect. Sadly, although your feature request would be really nice to have, I must decline it. Hopefully the reason is understood. |
|
The idea was not to package the logos directly into the application but to provide the possibility to set a picture per card. |
|
Oh, that sounds do-able. |
|
How would that work, in your mind? Would the user take a picture with the camera of a logo? Would they import a photo? Something else? |
|
For stocard I had taken some picture from a google image search and cropped it before setting it in the app. You may link to an existing picture from the user's gallery or better import / copy it to some sub-dir of the loyality-card-locker data dir? |
|
Or do directly a base64 encode of the picture. |
|
That would significantly raise the acceptance in some shops for this app. As soon as an employee sees the logo of his company he is more likely to accept scanning the loyalty card from an app. Some shops however have a strict no-app-policy. |
|
Really? I've not heard of that before. Interesting. I am for the idea of having a user selectable logo displayed with the summary on the main page and with the barcode. What is holding back the idea is a nice layout design for when there is and is not a logo present. I'm not the best that that, and am hoping that someone with an idea may contribute a suggestion. |
|
Why not using a default card icon as kind of placeholder if no picture was set? |
|
|
|
Some samples without and with icon. |
|
I'm not sure if it's really necessary to have the barcode displayed on the main page? |
|
This last set of pictures offers an interesting idea - it would be awesome to include pictures of the card. I was shopping at Costco and the cashier wanted to see the card, but then scanned my phone... but he said if I'd had pictures he would have accepted that. I'd be interested to try to implement this (know nothing about android programming but I'm a quick study) if x-jokay has all of those icons etc. I hate front end work. |
|
The screenshots were taken from the app stocard, I don't "own" those icons. |
|
If the issue is icons, I've used a number of icons from The Noun Project for other applications. @jimmyswimmy, if you are interested in taking this on and need some icons, maybe give that a look. The only thing which would need to be done is to ensure that the icons are release under a Creative Commons license and give credit in the README and in the About dialog. Here is an example of adding references for image resources. |
|
Has any progress happened in this issue yet, I am tempted to work on this issue as I also feel like it would be useful in shops that might be a bit hesitant on scanning a barcode from this app I'm currently thinking about how display it on the card page, I'll upload some scribbles at a later point as I am currently not near a laptop/desktop |
|
I've not made any progress on this. I encourage you to give it a shot! |
|
Not as I'm aware of :) Anyway, mobile payment solution providers start to integrate customer cards directly and will be used automatically during payment process. We may continue to use this app for customer cards which are not yet supported. |
|
Currently i have 3 ideas for the placement of the store logo, 2 i have mocked up in GIMP and the other is just having the logo over the barcode. I like it being by the store name, but that only works with stores that have a logo like the national trust, or the body-shop, most have their name in the logo so having it above the barcode may work but does not allow for low resolution images. Mockups: 1 |
|
@x-jokay yeah, android pay supports quite a few now, although I did find this useful when visiting a national trust property and my farther had forgotten his card |
|
I would expect that if the store had or did not have the name in the logo it would still be recognizable to the end user, and may not require having the store name and logo both. Could you create a mock-up with the logo above the barcode, to see what that is like?
Do you mean that if one were to use a low resolution image it would not look good, so for a good experience one would need to source higher resolution images? |
|
Here is a mock up of it above the barcode
|
|
I like the full sized barcode more, what do you think? Another thing that I am thinking is perhaps the order of the information could be better, to put the more relevant information closer to the top. For example:
Or, another option might be to omit the store name if there is an icon:
Do you have an opinion on the order of the presented data? Perhaps there is a better idea. |
|
I personaly prefer the current set up, It just kind of flows with the large images at the bottom and the small text at the top |
|
@x-jokay the app uses a sqlite database so it may be possible to use the SQLITE BLOB data type, but to keep the CSV exporting simple I might use your suggestion |
|
Just to double-check: Is this issue about just adding a logo, or are photographs of the card itself also considered? It has been mentioned in the comments, but I'm not sure if they're also considered (I do think images of the card, front and back, really add something. Using the front side of the card as the "logo" in the overview of cards works really well in mobile pocket which I was using before). If it helps, I'm happy to create a separate issue for that, though I suspect these could be tied together, also in terms of implementation. |
|
It was about adding a logo to the card (manually from the gallery) :) I think a separate issue for this will be a good idea. This issue can then be linked if it really makes sense for the implementation. |
|
Sadly due to workload related reasons I will probably not be able to do this now, I hope someone else picks this up. I had written some code, but it was mostly updating the database, sadly the laptop it was on died and I haddent committed it to my fork |
|
@TheLastProject umad? |
|
No clue what you're talking about, just copying over issues because I'm continuing this project (see the README of brarcher/loyalty-card-locker). I guess this import tool pinged everyone then. That's quite unfortunate, wasn't my intention to cause any type of spam. I'll report that to the import tool. Sadly GitHub doesn't offer any native support for copying issues yet I still want to keep track of what issues I have fixed in my fork so... yeah... |
You guessed right 🙄 |
|
I support adding a square image in place of the current icon as an initial letter. The user will choose ready-made pictures from the gallery. No need to take photos and photo cropping and editing functions. there will be no photos in your application, the user adds them himself. |
I think your idea is good and practicable. Legally, that shouldn't be a problem because the user decides for himself what it wants to use as an image. |
|
@redseasix yes, but it seems very difficult to provide a simple file chooser and set a locally stored image, so the discussion goes on ^^ |
|
Well, it's more that there are a lot of things to make and I want to make the things well. Given the knowledge I gained dealing with images by implementing front and back card image for the next release (which took a few attempts to get right) this should become easier to implement properly soon. |
|
Sorry this has been taking so long! It's finally probably ready (after some further testing) after @leaumar figured out why the tests were failing (I should never have used Thanks everyone for your patience and @leaumar for helping fix this :) |
|
Good news, after using Wear Codes on my Wear OS smartwatch ^^ Any plans on making your app work on Wear OS too? Stocard works on Wear OS too. |
|
See #25 for that. I don't have any WearOS devices myself though so that will probably need to be community-contributed. |
|
I don't think it will be this different than on an Android smartphone (beside the screen size, which surely need app optimizations). |
Saturday Jan 28, 2017 at 16:26 GMT
Originally opened as brarcher/loyalty-card-locker#86
It would be great to be able to set a small picture per card on the overview.
Or even having an overview with the logo and name of the card only:
https://c.mobilegeeks.de/wp-content/uploads/2013/02/stocard-04.jpg
The text was updated successfully, but these errors were encountered: