New feature: set an expiry date for a card

[TheLastProject]

Issue by ghost
Sunday Mar 18, 2018 at 17:04 GMT
Originally opened as brarcher/loyalty-card-locker#229

---

Suggestion:
Add a entry "card valid until" to the card editor. The date can be picked with the date picker.

Why is this useful?

Scenario:
There are various membership cards (e.g. library cards) that expire after a certain period of time. The function gives the user an overview when he has to extend his cards

[TheLastProject]

Comment by brarcher
Monday Mar 19, 2018 at 03:02 GMT

---

I never thought of a card that would expire. But you are right, that is possible.

In the previous layout adding new fields was easy: just throw it in the list. The new layout, though, will be trickier. Where would you think this data should be presented? Should it appear in the summary list, or only when viewing a single card? Could you give a mock-up of how you seeing it look?

What happens when a card expires? Is the field data only, in which case nothing happens?

When there is metadata I want to keep about a card I'll put it in the note field. Would adding the expiration date to the note field work (as a workaround) or would it be kludgy?

[TheLastProject]

Comment by ghost
Sunday Mar 25, 2018 at 19:37 GMT

---

I thought it would make sense to cross out the entry in the overview list and write the text of the entry in italics once the card has expired.
If you look at a single customer card, the field should of course also be visible, because you can edit the card from there.
As a workaround, I write "expired" in the notes field. It is nice, but changing or adding it is easy to forget.
I could give a mock-up of how I see it looking but it would take some time.

[TheLastProject]

Comment by brarcher
Monday Mar 26, 2018 at 14:43 GMT

---

I think a mock-up would be helpful. The edit screen is understandable:

The date can be picked with the date picker.

and the card selection screen is simple enough:

cross out the entry in the overview list and write the text of the entry in italics once the card has expired.

What about the view which looks at one card? I'm wondering how that should appear? Also crossing out and italics?

[TheLastProject]

I need to still fix the relevant unit tests but 6488dc0 implements this pretty much.

[TheLastProject]

Okay, the unit tests finally work. So the next release will contain the option to set an expiry :)