-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp build process #56
Conversation
I think the shell scripts are quite crazy and unsuitable because they are extremely hard to manage for being entirely semantic-less. |
You probably want to read the "metanorma.yml" files in each to determine what files to publish, and only publish the "cc" flavor? |
How would a semantically aware solution look like? What kind of semantics do we require?
Yes, that's the direction I'm going with. |
Necessary semantics:
I just don't think shell scripts are maintainable when working with content that spans formats. You're looking at Metanorma files and YAML at the same time. |
Encountering some build issues when running
Investigating why. |
You can skip 0812 for now. Please refer to cc-admin-documents for which documents to compile because the build there passes. |
@ronaldtse How much do we want to keep Jekyll? It turns out there's an incompatibility between latest jekyll and metanorma (via relaton-cli):
If we want to keep Jekyll (for building the non-metanorma HTMLs), an alternative solution may be to use separate Gemfiles for the different build stages. I am going to try that first. |
Yes, please use different gem files for the document builds and Jekyll builds. This is not the first time we've encountered the issue where Jekyll is bound to older gems. |
89fe0e6
to
0e59b12
Compare
|
||
build-standards: | ||
name: Build standards docs | ||
needs: build-site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the approach now to build 3 sites independently and then combining them in the directory to publish? Are we able to use the CalConnect styling for the metanorma mini-sites?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the approach now to build 3 sites independently and then combining them in the directory to publish?
Yes.
Are we able to use the CalConnect styling for the metanorma mini-sites?
Not at the moment. Will investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this approach requires a set of .liquid
templates (via relaton, via metanorma-cli) for the CalConnect style. If there exists none, I'll create them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observation: {% include
tag as used in Jekyll is not available in Relaton, as it is specific to Jekyll: https://github.com/jekyll/jekyll/blob/master/lib/jekyll/tags/include.rb
Meanwhile, Relaton uses straight liquid
.
This makes the current set of Jekyll _includes
and _layouts
unreusable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case you are not aware of the original approach, which is to build the documents, and input the Relaton Bib YAML files into Jekyll to render the site. This way Jekyll reads the Relaton files as native "data files".
Command run: scripts/add-all-cc-repos-as-submodules
…add as submodules
... to repopulate `metanorma.source.files` array of a target YAML, given a doc type, a document class, and a sub-directory from which to search documents.
de0cc0d
to
ec918b8
Compare
ec918b8
to
da59bca
Compare
…`public-review` and `pending-publication`
This reverts commit b9099aecb0f5cc9fbef332b6bd2f9cb977d81545. To prepare for another approach...
Oops, merged by accident. Undid the merge, and now this PR remains closed... |
Fixes #55 and potentially resolves #53 .