New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent body behaviour in delete methods #45

Open

KillWolfVlad opened this issue Feb 18, 2023 · 0 comments

Labels

question

Collaborator

KillWolfVlad commented Feb 18, 2023

endpoint method think that delete should have body

nest-http-client/src/parseEndpoint.ts

Line 76 in 582df46

if (["GET", "HEAD"].includes(method)) {

but delete method can't accept body like post or put

nest-http-client/src/httpClient.ts

Lines 28 to 31 in 582df46

    
           public async delete<T = any>( 
        
             url: string, 
        
             config?: AxiosRequestConfig, 
        
           ): Promise<T> {

The text was updated successfully, but these errors were encountered:

KillWolfVlad added the question label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment