From 5ff8e7e13189108529559eac40b8d5de43c281d5 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Wed, 24 Apr 2024 14:47:46 +0200 Subject: [PATCH 1/2] network_parameters: change bip21 schema liquidtestnet->liquidnetwork the schema doesn't need to convey the network, indeed for bitcoin we have only `bitcoin:` as schema for every network (mainnet, testnet, signet, regtest) This is indeed a breaking change and the liquidtesnet schema is used in the wild, however, since it's breaking only for testnet networks, it makes sense to change it. --- docs/source/examples/get_networks.json | 4 ++-- src/network_parameters.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/source/examples/get_networks.json b/docs/source/examples/get_networks.json index 8938b66af..949a60de9 100644 --- a/docs/source/examples/get_networks.json +++ b/docs/source/examples/get_networks.json @@ -220,7 +220,7 @@ "asset_registry_onion_url": "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/", "asset_registry_url": "https://assets-testnet.blockstream.info/", "bech32_prefix": "tex", - "bip21_prefix": "liquidtestnet", + "bip21_prefix": "liquidnetwork", "blech32_prefix": "tlq", "blinded_prefix": 23, "blob_server_onion_url": "", @@ -480,7 +480,7 @@ "asset_registry_onion_url": "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/", "asset_registry_url": "https://assets-testnet.blockstream.info/", "bech32_prefix": "tex", - "bip21_prefix": "liquidtestnet", + "bip21_prefix": "liquidnetwork", "blech32_prefix": "tlq", "blinded_prefix": 23, "blob_server_onion_url": "", diff --git a/src/network_parameters.cpp b/src/network_parameters.cpp index 0194cd0d2..5d6b93736 100644 --- a/src/network_parameters.cpp +++ b/src/network_parameters.cpp @@ -329,7 +329,7 @@ static std::map> registered_network { "asset_registry_url", "https://assets-testnet.blockstream.info/" }, { "asset_registry_onion_url", "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/" }, { "bech32_prefix", "tex" }, - { "bip21_prefix", "liquidtestnet" }, + { "bip21_prefix", "liquidnetwork" }, { "blech32_prefix", "tlq" }, { "blinded_prefix", 23u }, { "blob_server_url", std::string() }, @@ -713,7 +713,7 @@ static std::map> registered_network { "asset_registry_url", "https://assets-testnet.blockstream.info/" }, { "asset_registry_onion_url", "http://lhquhzzpzg5tyymcqep24fynpzzqqg3m3rlh7ascnw5cpqsro35bfxyd.onion/testnet/" }, { "bech32_prefix", "tex" }, - { "bip21_prefix", "liquidtestnet" }, + { "bip21_prefix", "liquidnetwork" }, { "blech32_prefix", "tlq" }, { "blinded_prefix", 23u }, { "blob_server_url", std::string() }, From 0d09b758b8384b2fa1730234d98d93ee12ae7509 Mon Sep 17 00:00:00 2001 From: Riccardo Casatta Date: Thu, 19 Dec 2024 17:28:47 +0100 Subject: [PATCH 2/2] docs: in CHANGELOG mention bip21 schema change for liquid testnet --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1036bfb35..18e51e247 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Changed +- Changed bip21 schema for liquid testnet networks, from `liquidtestnet` to + `liquidnetwork`. + ## Release 0.74.1 - 24-12-13 ### Added