Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan Sparrow QR PSBTs #202

Open
ddustin opened this issue Jan 20, 2025 · 1 comment
Open

Scan Sparrow QR PSBTs #202

ddustin opened this issue Jan 20, 2025 · 1 comment

Comments

@ddustin
Copy link

ddustin commented Jan 20, 2025

Issue:

  • It is extraordinarily difficult to add Jade to an existing quorum of multisig devices.

Description:

When adding a Jade to a multisig quorum managed by Sparrow, it is impossible to transmit a PSBT for signing using QR codes.

Sparrow has a protocol for doing multiple-QR codes to transmit the PSBT.

Every time the Jade scans the PSBT QR code sequence, it scans some of the QR codes then fails with an error saying "invalid psbt".

Current Behavior

  • The Jade attempts to read the sequential QR codes one time, failing if one or more QR scans fail

Desired Behavior

  • The Jade should continually scan the QR codes as the sequence repeats and attempt to stitch together the pieces it scans into a valid PSBT -- trying at least 3 cycles but ideally a dozen or even continually.
@JamieDriver
Copy link
Collaborator

The Jade attempts to read the sequential QR codes one time, failing if one or more QR scans fail
Simply not true. What makes you think this is happening ?

'invalid psbt' - I do not see this in the jade codebase. Did you mean "Unsupported QR/PSBT format" if so, this means the Jade has successfully scanned all the QR codes, and the resulting bytes are not a valid PSBT.

Jade does indeed scan the QR codes indefinitely until it has sufficient codes to rebuild the original message. If any codes are missed or error they are just ignored. It does not error if QR codes fail to scan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants