Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly relaxing the rowData checks for cbind #33

Open
LTLA opened this issue Nov 28, 2019 · 0 comments
Open

Slightly relaxing the rowData checks for cbind #33

LTLA opened this issue Nov 28, 2019 · 0 comments

Comments

@LTLA
Copy link
Contributor

LTLA commented Nov 28, 2019

Inspired by https://support.bioconductor.org/p/126722/.

The problem is what to do when a rowData field is not identical across cbind'd elements. Currently cbind throws an error, which is understandable (and safest) but inconvenient.

A more convenient approach would be to simply drop non-identical fields with a warning. This would allow people to proceed with cbinded results - most of the time, they won't even care that the fields are lost, given that it wouldn't make sense for them to be there anyway.

cbind already accommodates situations where the elements have non-identical rowData with non-overlapping names, so it doesn't seem much of a stretch to just drop fields instead of erroring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant