From dd93ccb561525e5fe3be4c8308c3e8e723150070 Mon Sep 17 00:00:00 2001
From: yzt <zityang@microsoft.com>
Date: Tue, 11 May 2021 16:38:04 +0800
Subject: [PATCH 1/2] Update version to 1.4.0 (#223)

---
 version.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/version.props b/version.props
index 2c844e47..7e1e8794 100644
--- a/version.props
+++ b/version.props
@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <VersionPrefix>1.3.0</VersionPrefix>
+    <VersionPrefix>1.4.0</VersionPrefix>
     <VersionSuffix>preview1</VersionSuffix>
     <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion>
     <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' != 'rtm' ">$(VersionPrefix)-$(VersionSuffix)-final</PackageVersion>

From acd1369ee26e6f9692f7404e007ef745248ab9d5 Mon Sep 17 00:00:00 2001
From: yzt <zityang@microsoft.com>
Date: Tue, 11 May 2021 17:27:06 +0800
Subject: [PATCH 2/2] Remove [Obsolete] of `ServerlessHub` sync negotiate
 method (#224)

Avoid breaking changes
---
 src/SignalRServiceExtension/TriggerBindings/ServerlessHub.cs    | 1 -
 test/SignalRServiceExtension.Tests/Trigger/ServerlessHubTest.cs | 2 --
 2 files changed, 3 deletions(-)

diff --git a/src/SignalRServiceExtension/TriggerBindings/ServerlessHub.cs b/src/SignalRServiceExtension/TriggerBindings/ServerlessHub.cs
index e079774c..60102033 100644
--- a/src/SignalRServiceExtension/TriggerBindings/ServerlessHub.cs
+++ b/src/SignalRServiceExtension/TriggerBindings/ServerlessHub.cs
@@ -69,7 +69,6 @@ protected ServerlessHub(IServiceHubContext hubContext = null, IServiceManager se
         /// <summary>
         /// Gets client endpoint access information object for SignalR hub connections to connect to Azure SignalR Service
         /// </summary>
-        [Obsolete("Please use async version instead.")]
         protected SignalRConnectionInfo Negotiate(string userId = null, IList<Claim> claims = null, TimeSpan? lifetime = null)
         {
             return NegotiateAsync(new NegotiationOptions
diff --git a/test/SignalRServiceExtension.Tests/Trigger/ServerlessHubTest.cs b/test/SignalRServiceExtension.Tests/Trigger/ServerlessHubTest.cs
index a73238a5..c96393f2 100644
--- a/test/SignalRServiceExtension.Tests/Trigger/ServerlessHubTest.cs
+++ b/test/SignalRServiceExtension.Tests/Trigger/ServerlessHubTest.cs
@@ -19,7 +19,6 @@ namespace SignalRServiceExtension.Tests.Trigger
     public class ServerlessHubTest
     {
         [Fact]
-        [Obsolete]
         private async Task ServerlessHubUnitTest()
         {
             var clientProxyMoc = new Mock<IClientProxy>();
@@ -56,7 +55,6 @@ public MyHub(IServiceHubContext serviceHubContext = null, IServiceManager servic
         }
 
         [FunctionName("negotiate")]
-        [Obsolete]
         public SignalRConnectionInfo Negotiate(string userId)
         {
             return base.Negotiate(userId);