Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Azure/azure-container-networking
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bdaa36f0f17f2689320eeb22ba80010c8250f65e
Choose a base ref
..
head repository: Azure/azure-container-networking
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 859f4e4a8efc92072e24be24aabbf8f3e8fa38f3
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 network/network_windows.go
2 changes: 1 addition & 1 deletion network/network_windows.go
View file
Original file line number Diff line number Diff line change
@@ -364,7 +364,7 @@ func (nm *networkManager) newNetworkImplHnsV2(nwInfo *EndpointInfo, extIf *exter
logger.Info("Successfully created hcn network with response", zap.Any("hnsResponse", hnsResponse))
} else {
if strings.Contains(err.Error(), "already exists") {
// fetch the network name again since the paralel CNI Add call has created the HNS network
// fetch the network name again since the parallel CNI Add call has created the HNS network
hnsResponse, err = Hnsv2.GetNetworkByName(hcnNetwork.Name)
if err != nil {
return nil, fmt.Errorf("Failed to get hcn network: %s due to error: %v", hcnNetwork.Name, err)

Check failure on line 370 in network/network_windows.go

GitHub Actions / Lint (1.22.x, windows-latest) 

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"Failed to get hcn network: %s due to error: %v\", hcnNetwork.Name, err)" (err113)

Check failure on line 370 in network/network_windows.go

GitHub Actions / Lint (1.23.x, windows-latest) 

do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"Failed to get hcn network: %s due to error: %v\", hcnNetwork.Name, err)" (err113)