Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docstrings to MyMutableMapping to fix github.io rendering issue #2360

Closed
kristapratico opened this issue Jan 11, 2024 · 0 comments · Fixed by microsoft/typespec#5707
Closed

Comments

@kristapratico
Copy link
Member

Right now we're getting the docstrings from collections.abc: https://github.com/python/cpython/blob/2e7577b622616ef5ff2d1460fb5bebf845f0edf3/Lib/_collections_abc.py#L919

The issue is that collections.abc use single quotes in their docstrings and for some reason this completely breaks sphinx and puts the docstring into type hint field like:

image

@iscai-msft tested this and found that if we override the docstrings in MyMutableMapping and use double-quotes we can fix this in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant