Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight ExternalDNS Config Refactor #363

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

jaiveerk
Copy link
Collaborator

Description

Slight refactor to simplify process of generating externaldns resources to make CRD support implementation smoother

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • added UTs

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=141247e

bosesuneha
bosesuneha previously approved these changes Feb 11, 2025
Copy link
Member

@bosesuneha bosesuneha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=b5f8b3b

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=b2068f9

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=dd38289

Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to regen fixtures. failing unit

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=a8b10fc

@OliverMKing
Copy link
Collaborator

still failing unit

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=4de98f6

OliverMKing
OliverMKing previously approved these changes Feb 13, 2025
@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=723f86c

OliverMKing
OliverMKing previously approved these changes Feb 13, 2025
bosesuneha
bosesuneha previously approved these changes Feb 13, 2025
@jaiveerk jaiveerk dismissed stale reviews from OliverMKing and bosesuneha via 4843669 February 14, 2025 18:09
@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=4843669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants