-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slight ExternalDNS Config Refactor #363
base: main
Are you sure you want to change the base?
Slight ExternalDNS Config Refactor #363
Conversation
/ok-to-test sha=141247e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…dns-refactor-cont
/ok-to-test sha=b5f8b3b |
/ok-to-test sha=b2068f9 |
…n case of weird edge case
/ok-to-test sha=dd38289 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to regen fixtures. failing unit
/ok-to-test sha=a8b10fc |
still failing unit |
/ok-to-test sha=4de98f6 |
/ok-to-test sha=723f86c |
4843669
/ok-to-test sha=4843669 |
Description
Slight refactor to simplify process of generating externaldns resources to make CRD support implementation smoother
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: