Http crd flag #362
Open
Http crd flag #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OliverMKing
reviewed
Feb 12, 2025
OliverMKing
reviewed
Feb 12, 2025
| privateNic := manifests.NewNginxIngressController("private", "private.ingress.class") | ||
| privateNic.Spec.HTTPDisabled = true | ||
| if err := upsert(ctx, c, privateNic); err != nil { | ||
| return fmt.Errorf("ensuring private NIC: %w", err) |
There was a problem hiding this comment.
I've changed the test to mirror the logic in the test under it rather than the private test above it, lmk what you think of it
|
/ok-to-test sha=40c61f7 |
OliverMKing
requested changes
Feb 12, 2025
|
/ok-to-test sha=00cd7c2 |
|
e2e tests are all failing. https://github.com/Azure/aks-app-routing-operator/blob/main/docs/e2e.md |
|
/ok-to-test sha=cf4217a |
1 similar comment
|
/ok-to-test sha=cf4217a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the HTTPDisabled flag to the CRD for the NginxIngressController.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: