Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: add support for not fixed item heights #31

Open
marcin-michalek opened this issue Dec 16, 2016 · 3 comments
Open

Improvement: add support for not fixed item heights #31

marcin-michalek opened this issue Dec 16, 2016 · 3 comments

Comments

@marcin-michalek
Copy link

Hello,

thanks for a great library! Do you have any thoughts on how to use it on not fixed item height? For instance I have an item view with multiple text views which are generated in the adapter based on adapter data. If item view is higher than the defined fixed height the item view is cut off at the bottom.

@mig35
Copy link
Member

mig35 commented Dec 19, 2016

@marcin-michalek we don't think we will add this support soon

@Kisty
Copy link

Kisty commented Jan 12, 2017

The way I'd do it is to get all the data upfront and manually measure text height and text layout before setting the Adapter to the RecyclerView.

@marcin-michalek
Copy link
Author

Yep - that's how I did it. Foretunatelly, I had a max of three items in the carousel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants