Serialization failure in service contract (webapi/AMQP and maybe more)

[thomas-kl1]

Error you will face:

"Sources" is not supported. Correct the field name and try again.

It's because if you pass to \Magento\Framework\Webapi\ServiceInputProcessor::convertValue the result of \Magento\Sales\Api\OrderRepositoryInterface::get (or getList), the Order object is badly formatted because of this plugin: \Ampersand\DisableStockReservation\Plugin\Model\OrderRepositoryPlugin. It seems that for some reason, the sourceCode is not serialized when Magento tries to rebuild the Sources extension attribute of the order (Magento\InventorySourceSelectionApi\Api\Data\SourceSelectionItemInterface).

Anyway I don't see any usage of this extension attribute in the code (Sources) so I guess it's safe to remove it and the plugin?

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Api/etc/extension_attributes.xsd">
    <extension_attributes for="Magento\Sales\Api\Data\OrderInterface">
        <attribute code="sources" type="Magento\InventorySourceSelectionApi\Api\Data\SourceSelectionItemInterface[]" />
    </extension_attributes>
</config>

[thomas-kl1]

My temporary fix is to unset the sources:
$order->getExtensionAttributes()?->setSources([]);