Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cruets not fillable from tanks,etc #55

Open
MoraglarKhilen opened this issue Apr 4, 2019 · 6 comments
Open

Cruets not fillable from tanks,etc #55

MoraglarKhilen opened this issue Apr 4, 2019 · 6 comments

Comments

@MoraglarKhilen
Copy link

MoraglarKhilen commented Apr 4, 2019

Tested. Cannot Fill Empty Cruets with Milk nor Water from
Seared Gauge/Tank etc from TC
Tanks from IC2
Sink or Milk Bottle from CfB

@liach
Copy link

liach commented Apr 5, 2019

It will need the fluid handler capability.

@Dockter
Copy link
Member

Dockter commented Jun 30, 2020

@liach can you elaborate please?

@liach
Copy link

liach commented Jun 30, 2020

the curet item should like override getCapabilityHandler to return a fluid item capability handler when the fluid item capability is passed in. this is what modded fluid systems use to transfer fluids in items.

@liach
Copy link

liach commented Jun 30, 2020

For the purpose of json-definable items, you might consider putting forge-bound capabilities in some sort of map that can be populated from json stuff read in item definition, and dispatch capabilities based on contents filled in that map.

@Dockter
Copy link
Member

Dockter commented Aug 19, 2020

@Dockter
Copy link
Member

Dockter commented Aug 19, 2020

I will need to rollback the change in MixinEntityCow where I create the milk cruet items if we can implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants