Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confetti doesn't fit to expanding window #25

Open
Evan-Nishi opened this issue Aug 12, 2020 · 1 comment · May be fixed by #39
Open

Confetti doesn't fit to expanding window #25

Evan-Nishi opened this issue Aug 12, 2020 · 1 comment · May be fixed by #39

Comments

@Evan-Nishi
Copy link

When a window is initially not in full screen on initial load and is then expanded, the confetti is cut off and only loads for the initial size of the window. This works correctly when the window is fullscreen on the initial load and is minimized than re-expanded.

This was tested using react in the chrome browser.

Here is an example:
image

@charliedua
Copy link

charliedua commented Nov 18, 2020

Tried to reproduce this issue, here are my findings.

Reproducible: Yes ✔️

Findings:

  • As explained in the comment, initially when the site is loaded in windowed mode the confetti is shown,
  • However when the window is resized to a bigger height and/or width, the confetti is only visible on the previously visible region. (see image)

Step to reproduce:

  • Open any website using confetti-js. (I am using this) in windowed mode.
  • Resize the window to a bigger height and/or width.
  • Observe the page for a while, the confetti is only visible on the previously visible region. (see image)

image

@michaelkofron michaelkofron linked a pull request Oct 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants