Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOS / snooping / blocking malicious access #39

Open
AdamISZ opened this issue Jun 16, 2017 · 1 comment
Open

DOS / snooping / blocking malicious access #39

AdamISZ opened this issue Jun 16, 2017 · 1 comment
Milestone

Comments

@AdamISZ
Copy link
Owner

AdamISZ commented Jun 16, 2017

One trivial point is to ensure no security leaks from arbitrary server access.

More important, considering DOS/snooping generally from client-> server. We don't want:

  • Costless initiation of transactions, locking server utxos. This is addressed by Fees implementation as per #8 #30 in as much as client cannot backout without paying fees.
  • Costless setup of parameters, which requires use of an address by the server (see Bad faith taker spy not filling orders so that it learns which UTXOs belong to which maker, allowing future unmixing JoinMarket-Org/joinmarket#156). A critical difference here is that this only grabs fresh addresses, which will not be used again by the server, it does not get utxo information. The client only sees the server utxos at the point they're consumed on the blockchain (TX1), at which point the client has already committed, with confirmations, his own TX0, which costs him to back out. For this reason, I don't think this attack has any real incentive, in the way that it did in pre-0.2 Joinmarket, so it isn't as big of a concern.
  • Too many simultaneous requests/coinswaps: currently the server has a configurable maximum_concurrent_coinswaps (default 3), it will report "busy" to clients after that and refuse to negotiate until one of the pre-existing ones is finished.
  • General DOS with request flooding. This point will need more addressing, somehow.
@AdamISZ AdamISZ added this to the 0.1 milestone Jun 16, 2017
@AdamISZ
Copy link
Owner Author

AdamISZ commented Jun 17, 2017

b4c3d12 is addressing the first point in the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant