Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[👨‍💻 code improvement] TileItemsService.ts could be resued between extension and webpart #26

Open
Adam-it opened this issue Dec 7, 2022 · 0 comments
Open

[👨‍💻 code improvement] TileItemsService.ts could be resued between extension and webpart #26

Adam-it opened this issue Dec 7, 2022 · 0 comments
Labels
📚 documentation Improvements or additions to documentation ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🤚 help wanted Extra attention is needed

Comments

@Adam-it
Copy link
Owner

Adam-it commented Dec 7, 2022

Is your feature request related to a problem? Please describe.
The TileItemsService is added in both places but could be added as an spfx lib and resued in both places as and added package to the solution

Additional context
Best to also remember to update readme files to provide build instructions
@Adam-it Adam-it added 📚 documentation Improvements or additions to documentation ⭐ enhancement New feature or request 🤚 help wanted Extra attention is needed 💪 good first issue Good for newcomers labels Dec 7, 2022
@Adam-it Adam-it changed the title TileItemsService.ts could be resued between extension and webpart [👨‍💻 code improvement] TileItemsService.ts could be resued between extension and webpart Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation ⭐ enhancement New feature or request 💪 good first issue Good for newcomers 🤚 help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Adam-it