Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ .env.template Change] change is required due to clientId is not supported on Android and is interpreted as serverClientId #212

Open
abhinavs1920 opened this issue Dec 23, 2024 · 5 comments

Comments

@abhinavs1920
Copy link
Contributor

🐛 Describe the bug

.env.template Change: clientId Not Supported on Android

Description

The application generates a warning message during Google Sign-In implementation on Android because clientId is being used instead of serverClientId. This issue needs to be addressed by updating the .env.template configuration to use the correct parameter name.

Current Warning Message

W/google_sign_in( 4272): clientId is not supported on Android and is interpreted as serverClientId. Use serverClientId instead to suppress this warning.

Current Implementation

In the current .env.template:
GOOGLE_SIGNIN_ANDROID_CLIENT_ID=

Required Change

The environment variable should be updated to:
SERVER_CLIENT_ID=

Impact

  • This warning appears in the Android logs during Google Sign-In operations.
  • While the application still functions (as clientId is being interpreted as serverClientId), it's not following best practices.
  • The warning creates unnecessary noise in the logs.
  • Future versions of the Google Sign-In SDK might deprecate this fallback behavior.

Steps to Reproduce

  1. Set up the application with the current .env.template.
  2. Configure Google Sign-In.
  3. Check Android logs during the sign-in process.
  4. Observe the warning message.

Proposed Solution

  1. Update .env.template to use SERVER_CLIENT_ID instead of GOOGLE_SIGNIN_ANDROID_CLIENT_ID.
  2. Update all related documentation to reflect this change.
  3. Add a migration guide for existing users.
  4. Update any related code that references this environment variable.
@abhinavs1920
Copy link
Contributor Author

Can you please assign this issue to me?
Thanks!!
@mdmohsin7

@abhinavs1920 abhinavs1920 changed the title [ .env.template Change] due to clientId is not supported on Android and is interpreted as serverClientId [ .env.template Change] change is required due to clientId is not supported on Android and is interpreted as serverClientId Dec 23, 2024
@khushi-hura
Copy link

hey @mdmohsin7 I can work on this, can it be assigned to me?

@abhinavs1920
Copy link
Contributor Author

@mdmohsin7
Raised PR for the last issue assigned to me.
Can I get to work on this issue now?
Thanks!!

@HelloSniperMonkey
Copy link
Contributor

hey @mdmohsin7 can i work on this issue as it has been not assigned in a long time

@abhinavs1920
Copy link
Contributor Author

@mdmohsin7
My last PR has been merged.
Can I work over this issue now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants