-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building instructions for Linux distro packaging #8
Comments
Hi @hroncok, we would love to have a package of lib3MF for Fedora! With the latest large update, we can now provide lib3MF with soname version. This can be configured in the CMakeLists.txt (it is disabled by default). The required headers for the C-interface are:
Lib3MF is meant to be updated and bugfixed regularly. As you see from the latest history of the project, there can be very large updates in between. Anything else you need? Cheers |
I might get back to this, thanks for the reply. |
Looking at the git history: Tagged release(s) would be nice, if that works for you. |
This will not be a problem. I'll update the actual version-numbering to be consistent with the (future) release tags. |
Published a release: |
I'm running
And it seems none of the build flags are honored. |
Do you mean the flags like CMAKE_CXX_FLAGS ? A lot of these flags will actually be set (or rather extended) in the CMakeLists.txt. I assume you are able to build with the simple GenerateMake.sh-script in the cmake-folder of the repo? |
No, I'm just running cmake: build.log
|
I do not know why some of the build flags are not used and others are (like -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON). The reported unused flags
are neither explicitly used or set in the CMake configuration. |
Is Also the name of the output file is |
Hi @hroncok, the cmake build stuff is now working for me on OBS (see lib3MF1.spec). This is certainly not matching actual distribution requirements (e.g. debug package disabled, ...), but it could maybe serve as base for further discussion. |
Thanks. I've got stuck at the debug package and never got back to it. |
Under Arch Linux I see:
|
You can disable the tests with |
Hi, just wondering if this initiative to create a Fedora package for lib3mf ever progressed further than the conversation here? I don't see a package on Fedora so assume it didn't complete but if there's a package under review or any further progress I'd be interested. I'm working on a cross platform application where we'd like to add support for importing 3mf files and our platforms include Windows, OSX, Ubuntu and RHEL. Thanks |
I have never got past the "debug package disabled" problem. I had nothing useful and I gave up. |
Thanks for trying, @hroncok . Maybe with version 2, which was released last year, this might have become easier! |
OK thanks both. @hroncok It wasn't totally clear what the "debug package disabled" problem was looking at the build.log attached earlier on to this issue. Were you expecting the -DNDEBUG flag to have been used and it wasn't? If yes this might be caused by the fact that CMAKE_BUILD_TYPE isn't given a default value (eg RELEASE) in the Lib3MF cmake logic so I don't think any value you give to CMAKE_C_FLAGS_RELEASE would get used when running cmake. At least not in linux with a single configuration generator Or maybe it was the fact that some of the other flags were unused. I see support for variables similar to INCLUDE_INSTALL_DIR, LIB_INSTALL_DIR has been added (variables called CMAKE_INSTALL_INCLUDEDIR, CMAKE_INSTALL_LIBDIR which I think follow the GNUInstallDirs cmake package's naming convention for the variable names). |
I honestly don't remember. As said, I gave up. This was 4 years ago. |
I did a bit more work on this because we use a private EPEL repository to manage the 3rd party libraries for our software - so I've had to prepare a EPEL lib3mf package for RedHat\CentOS platforms using the rpm toolset. I found two issues that I had to fix before creating the package successfully:
I've attached the rpm spec file and the patch I created to apply the two changes above |
Good catch with the @DannyHindson Shall we try to package this library in EPEL proper? What EPEL versions are we taking about here? |
Yes that would be great. We're using EPEL 7 and I had been developing\testing that rpm spec file on CentOS 7.7 |
I have sent and e-mail to @DannyHindson to continue the off-topic discussion elsewhere. Will let you know here once (if) there is an official Fedora/EPEL package. |
This is on topic, so noting it here. The package installs header files (as well as Python and Pascal sources) to:
That seems rather unpleasant. Shall it at least be namespaced somehow? |
I will move the files around to have:
Should that be the default? |
I've opened #199 -- another blocker to get this packaged. |
The lib3mf package is on it's way to official EPEL 7 https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-6ecb9adca3 |
The newer CMake improvements make it possible to have debian and rpm based packages. Kindly see the work done in #346 |
Hello, I'm a packager from Fedora. I'd like to package lib3mf, but I miss any building instructions.
There is Makefile that generates lib3MF.so.
I would like to get a .so with soname version, such as: lib3MF.so.1.0.0.
I would like to know what header files should I put into /usr/include and where exactly.
Would that please be possible? I'm willing to send a Pull Request changing the Makefile if you tell me what should be the outcome.
BTW Should I expect a release or is this going to be a rolling thing?
Thank you.
The text was updated successfully, but these errors were encountered: