Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HybridCustody child/owned accounts view #4

Closed
sisyphusSmiling opened this issue Jul 5, 2023 · 4 comments · Fixed by #7
Closed

Add HybridCustody child/owned accounts view #4

sisyphusSmiling opened this issue Jul 5, 2023 · 4 comments · Fixed by #7

Comments

@sisyphusSmiling
Copy link

Description

Add an account view component that lists an address's child and owned account addresses. May also resolve the MetadataViews.Display included in either/both OwnedAccount.display or/and ChildAccount.display as defined in the HybridCustody contract.

Reference

Below are some queries that might help resolve the child account addresses and app-defined Display views.

Note that ChildAccount.display is settable by the parent while OwnedAccount.display is settable by the owner of the child account, at least in the current construction. Being able to see child & owned account addresses would be helpful enough on its own and avoid any thrash created by changes made to metadata access patterns while finalizing.

get_owned_addresses.cdc is in PR atm, but pretty similar to retrieving child addresses.
@sisyphusSmiling sisyphusSmiling changed the title Add Hybrid Custody accounts view Add HybridCustody child/owned accounts view Jul 5, 2023
@LanfordCai
Copy link
Member

Haha, I had a similar thought before, but after submitting a PR for linked-accounts, I realized that the project is still under active development and there could be many changes happening. So I decided to wait until it goes live on the mainnet before adding support. Is the project stable now?

@sisyphusSmiling
Copy link
Author

The new repo location is onflow/hybrid-custody (thanks for reminding me I should add a disclaimer in the linked-accounts README!) and is still undergoing changes before another testnet deployment - ETA by EOW next week at the latest. That said, the interface for discovering child and owned account addresses is stable

@LanfordCai
Copy link
Member

Great! Will start this after submitting the Hackathon project!

@LanfordCai LanfordCai mentioned this issue Aug 11, 2023
Merged
13 tasks
@LanfordCai
Copy link
Member

@sisyphusSmiling Please take a look at https://flowview.app and give me some feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: hybrid custody 33-Labs/flowview
2 participants
@LanfordCai @sisyphusSmiling