Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp syscall tests occasionally fail #687

Open
FabijanC opened this issue Jan 20, 2025 · 0 comments
Open

Timestamp syscall tests occasionally fail #687

FabijanC opened this issue Jan 20, 2025 · 0 comments
Labels
bug Something isn't working Hard Task is hard to fix help wanted Extra attention is needed OnlyDust testing Related to code testing

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Jan 20, 2025

Description

Timestamp tests occasionally fail.

Tests known to fail (not sure if there's more):

  • test_advancing_time::timestamp_syscall_set_in_future
  • test_advancing_time::timestamp_syscall_contract_constructor
    • the most frequently failing timestamp test
    • CI log

Basically, waiting/sleeping for 1 second doesn't increment the time used by syscalls in Starknet contracts; the time stays the same.

Only fails on CI, ran a loop of several hundreds iterations, couldn't make it fail locally.

Mitigation attempts

Restarting the workflow helps.

Tried extending to sleeping for 1.1 s: #681

  • problem persisted

Tried extending to sleeping for 1.5 s: 8f74b33

  • problem persisted

Perhaps we can extend to 2 s?

@FabijanC FabijanC added bug Something isn't working testing Related to code testing labels Jan 20, 2025
@FabijanC FabijanC changed the title Tests Timestamp syscall tests occasionally fail Jan 20, 2025
@FabijanC FabijanC added help wanted Extra attention is needed OnlyDust Hard Task is hard to fix labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hard Task is hard to fix help wanted Extra attention is needed OnlyDust testing Related to code testing
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant