Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check commit_with_diff() inside generate_new_block_and_state() #501

Closed
mikiw opened this issue Jun 18, 2024 · 1 comment · Fixed by #503
Closed

Check commit_with_diff() inside generate_new_block_and_state() #501

mikiw opened this issue Jun 18, 2024 · 1 comment · Fixed by #503
Assignees
@mikiw

Comments

@mikiw
Copy link
Contributor

mikiw commented Jun 18, 2024

No description provided.

@mikiw mikiw self-assigned this Jun 18, 2024
@FabijanC
Copy link
Contributor

Transferring from #484:

Refactoring will probably have to deal with this problem of redundant state committing:

In handle_accepted_transaction, we call commit_with_diff and optionally generate_new_block_and_state:
https://github.com/0xSpaceShard/starknet-devnet-rs/blob/3ad81456092a2da939be1f590855cea2c18ce40c/crates/starknet-devnet-core/src/starknet/mod.rs#L457-L480

In generate_new_block_and_state we call commit_with_diff again:
https://github.com/0xSpaceShard/starknet-devnet-rs/blob/3ad81456092a2da939be1f590855cea2c18ce40c/crates/starknet-devnet-core/src/starknet/mod.rs#L335

@mikiw mikiw linked a pull request Jun 19, 2024 that will close this issue
Remove calling commit_with_diff from generate_new_block_and_state #503
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikiw mikiw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove calling commit_with_diff from generate_new_block_and_state 0xSpaceShard/starknet-devnet
2 participants
@mikiw @FabijanC